Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed automated tests entry point on Windows. #1062

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martnpaneq
Copy link
Contributor

Suggested merge commit message (convention)

Internal: Fixed automated tests entry point on Windows. Closes ckeditor/ckeditor5#17797.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but now we do not need to manually replace \ with /.

Using the upath.posix.* namespace is not needed.

Also, upath is not added to dependencies.

@przemyslaw-zan
Copy link
Member

The file does not generate properly for me:

$ yarn run test -f enter
yarn run v1.22.22
$ node --max_old_space_size=4096 node_modules/@ckeditor/ckeditor5-dev-tests/bin/testautomated.js -f enter
(node:14020) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
⚠ You're running tests in dev mode - some error protections are loose. Use the `--production` flag to use strictest verification methods.
karma-webpack does not support custom optimization configurations for webpack, the optimizations passed will be ignored.

START:
Webpack bundling...
asset runtime.js 10.7 KiB [emitted] (name: runtime)
asset commons.js 1.1 KiB [emitted] (name: commons) (id hint: commons)
asset entry-point.1182466350.js 473 bytes [emitted] (name: entry-point.1182466350)
Entrypoint entry-point.1182466350 12.2 KiB = runtime.js 10.7 KiB commons.js 1.1 KiB entry-point.1182466350.js 473 bytes

ERROR in ./build/.automated-tests/entry-point.js 3:66
Module parse failed: Bad character escape sequence (3:66)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| import "C:/Repositories/ckeditor5/external/ckeditor5-dev/packages/ckeditor5-dev-tests/lib/utils/automated-tests/leaksdetectorbefore.js";
| import "C:/Repositories/ckeditor5/external/ckeditor5-dev/packages/ckeditor5-dev-tests/lib/utils/automated-tests/licensekeybefore.js";
> import "C:\Repositories\ckeditor5\packages\ckeditor5-enter\tests\utils.js";
| import "C:\Repositories\ckeditor5\packages\ckeditor5-enter\tests\shiftentercommand.js";
| import "C:\Repositories\ckeditor5\packages\ckeditor5-enter\tests\shiftenter.js";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script for automated tests in ckeditor5-dev-tests package does not exclude ignored paths on Windows
3 participants